-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates required to make master compatible with current spree master (2.1.0.beta) #15
base: master
Are you sure you want to change the base?
Conversation
- Use Spree namespaced i18n helper - Correct path for 'delete' icon
Is this project still being maintained? This pull request is great and should be merged. |
@sohara @greatislander @jroes All, I apologize. I never noticed this pull request. Can I get some feedback on if it is still valid and I'll merge it. Thanks |
@jsqu99 It's valid in so far as it's working well in our app. But I haven't tested it out in a stock spree store. Would probably be a good idea to do that prior to merging. |
@sohara I'm just now finding this repo. Did you ever get a chance to test in stock spree store? |
@jpdesigndev I don't think I ever did. In the end we just forked the extension and we're using that. You can find our fork here: https://github.com/littlebitselectronics/spree_reuse_credit_card We're running against spree core 2-0-stable, on this ref: https://github.com/spree/spree/tree/3fd1535e75d383fa7119d2f3b985f8c12731302c |
Add support for spree 2-2
Update to point to spree 2.2 release
Move assets to correct folder root
- Since there's no longer a table, the check for credit cards on the list is base on the visibles div's inside the 'existing_cards' element
…edit_cards_view Refactor existing credit cards view
…edit_cards_view - Fix credit card list style on mobile
…edit_cards_view Refactor existing credit cards view
- Hide the delete option for existing card - Credit card type and last digits in the same column
…edit_cards_view Refactor existing card list
…edit_cards_view Change add new credit card message
…edit_cards_view Existing credit cards style
…redit_cards_view Always show the Add new credit card option
…redit_cards_view Refactor existing credit cards view
…aved_credit_cards Show user saved credit cards
Title line says it all... let me know if there are any questions.
Cheers,
Sean
cc @BDQ