spree-2-2-stable updates #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omizations, tweak cart presentation
…rge! in the order model of spree_core.
Update merge! method within order_decorator to match the syntax of merge...
Calculation was amount * length of number string instead of amount * number.
…figuration Previously, product customization pricing only had access to the product customization options. We have a use case where the customization needs access to the overall line_item configuration. Specifically, we have a customization whose price is a percentage of (the base line_item price plus the price of a separate customization). This change just associates each product customization with its host line_item before computing customization prices.
|
+1 |
|
There are quite a lot of changes within this PR. I can see at about the halfway point the tests were working. Could we please get this back to having those passing tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm not sure how active this extension still is, though i do see that radar committed to it earlier this year.
If it's still active, these are changes that we've been using on a production spree-2-2 site for the past few months and would like to contribute back to the base repo (obviously not into master but into an appropriate new branch).
If this isn't an active extension, any advice on a more current extension to use would be greatly appreciated.
Thanks!