Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

teohhanhui
Copy link
Contributor

Do we really have to create an override for each and every moment plugin?

@guybedford
Copy link
Member

Let me know if you want to look at setting npm:moment as the main entry here? I will wait for your response further here.

@teohhanhui
Copy link
Contributor Author

If we have to provide an override for each moment plugin anyway, why not change the main moment package to not use the global format, and just shim the plugins where necessary?

@guybedford
Copy link
Member

@teohhanhui we shouldn't need to provide an override for each moment plugin as most npm packages are designed to work in jspm. The overrides would only be needed for those that don't work out of the box.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants