Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better Jade support #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gittycat
Copy link

@gittycat gittycat commented Jul 2, 2015

Jade has two comment styles:
//- for comments that are to be stripped before generation to html
// for comments that get converted into in the html.

The //- style comment is important in Jade and it requires the changes to the js regex that I've made.

gittycat added 2 commits July 2, 2015 13:22
Jade allows //- for comments, which didn't work with the js rules.
@BendingBender
Copy link
Contributor

Nice work! It'll take time for me to merge this because I'll have to implement tests for the introduced functionality. You could help me with this if you want to.

@Frizi
Copy link
Contributor

Frizi commented Jul 6, 2015

Just one thing. This pull request includes package.json change that should not be merged.

@shenqihui
Copy link

@gittycat
Can i just fork your branch and change pakcage.json back and make a pull request ?
I meet some bug width jade and your idea can fix it .
Thanks .

@Frizi
Copy link
Contributor

Frizi commented May 29, 2018

@shenqihui it's three years old and inactive, so surely nobody will be mad at you. When you're at it, remember that Jade was renamed to pug.

@gittycat
Copy link
Author

gittycat commented May 29, 2018

Done, pull request is here #134
It's forked from the current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants