Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTestTemplate causing Expected () to start arrow function, but got ';' instead of '=>' ` warning #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Miroku87
Copy link

Modified the getTestTemplate function. The check for test availability wasn't accurate enough. var || 'default' does not cover a lot of episodes. Infact I was getting an Expected () to start arrow function, but got ';' instead of '=>' warning because test was a series of blank spaces so it wasn't undefined so it wasn't been converted in true and the trim would transform it in an empty string. Lately return (); threw the warning.

Modified the getTestTemplate function. The check for `test` availability wasn't accurate enough. `var || 'default'` does not cover a lot of episodes. Infact I was getting an `Expected () to start arrow function, but got ';' instead of '=>' ` warning because `test` was a series of blank spaces so it wasn't undefined so it wasn't been converted in `true` and the trim would transform it in an empty string. Lately `return ();` threw the warning.
@coveralls
Copy link

coveralls commented Apr 11, 2017

Coverage Status

Coverage remained the same at 97.571% when pulling 9c07c65 on Miroku87:patch-1 into 704d289 on jsoverson:master.

@Miroku87
Copy link
Author

I've just noticed that the last check with the RegExp should be like this /^\s+$/.test(test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants