Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reconsile key formats, update keys, support JWK, re-enable CI #553

Merged
merged 4 commits into from
Sep 29, 2021
Merged

refactor: reconsile key formats, update keys, support JWK, re-enable CI #553

merged 4 commits into from
Sep 29, 2021

Conversation

panva
Copy link
Contributor

@panva panva commented Sep 27, 2021 •
edited
Loading

This PR

  • enables CI using GitHub Actions (skipped for PRs that only touch the libraries json files)
  • extends the private / public key format support
    • JWK (as a JSON string)
    • PEM RSA PKCS1
    • PEM PKCS8
    • PEM SPKI
    • PEM X.509 Certificates
  • updates the public/private key placeholders to include the supported formats (closes What to paste for the public key or certificate is vague #551)
  • fixes issues with the key downloader conformance
  • when automatically resolved JWK is used its JWK value is actually put in the public-key input
  • fixes ES512 skip to check for the WebKit engine rather than Safari as a browser vendor
  • updates default keys to be in unified PKCS8/SPKI format (rather than SEC1 and PKCS1)

panva
panva commented Sep 27, 2021
View reviewed changes
libraries.js
@@ -3,7 +3,7 @@ const { Octokit } = require("@octokit/rest");
const dotenv = require("dotenv").config();
const getLanguages = require("./views/website/libraries/support/get-languages.js");
const octokit = new Octokit({
auth: process.env.GITHUB,
auth: process.env.GITHUB || process.env.GITHUB_TOKEN,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in GitHub Actions a read-only GITHUB_TOKEN environment variable is always present

panva
panva commented Sep 27, 2021
View reviewed changes
views/website/layout.pug
Comment on lines -76 to +80
div
div(id="consent_blackbar")
div(id="teconsent" style="position: absolute; bottom: -100px;")
script(async="async" src="//consent.trustarc.com/notice?domain=auth0banner.com&c=teconsent&js=nj&noticeType=bb&text=true" crossOrigin)
if process.env.NODE_ENV === "production"
div
div(id="consent_blackbar")
div(id="teconsent" style="position: absolute; bottom: -100px;")
script(async="async" src="//consent.trustarc.com/notice?domain=auth0banner.com&c=teconsent&js=nj&noticeType=bb&text=true" crossOrigin)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it messes the headless browser tests.

@panva panva requested a review from Sambego September 27, 2021 11:46
@Sambego Sambego merged commit 3997bdd into jsonwebtoken:master Sep 29, 2021
@panva panva mentioned this pull request Sep 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sambego Sambego Awaiting requested review from Sambego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What to paste for the public key or certificate is vague
2 participants
@panva @Sambego