Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated libs #241

Closed
wants to merge 1 commit into from
Closed

Updated libs #241

wants to merge 1 commit into from

Conversation

yuriy-yarosh
Copy link
Contributor

@yuriy-yarosh yuriy-yarosh commented Jan 17, 2023 •
edited
Loading

Updated all the libs for #240 to the most recent versions, changed outputs a bit.
See PR comments.

@Duologic
Copy link
Member

May I suggest creating separate PRs per lib?

@yuriy-yarosh
updated
0007fac 
Revert "updated"

This reverts commit c4b6a85.
@yuriy-yarosh
Copy link
Contributor Author

yuriy-yarosh commented Jan 17, 2023 •
edited
Loading

@Duologic Sure, will split this up, if it'll help with the review.

It would be best to consolidate all the config.jsonnet file structure and the version matrices - automate the updates with a dedicated build task. Updating current versions just helped me with getting a grasp over general structure and styling inconsistencies.

So, I'll be making some ammends to extract versioning into a separate version.json files for further automation, if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuriy-yarosh @Duologic