Skip to content

fix: Incorrect page navigation throughout JSON Schema website #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Utkarsh-123github
Copy link
Member

What kind of change does this PR introduce?

Old incorrect navigations :

  • Get Started Overview -> Creating your first Schema
  • Get started overview <- Create your first schema -> Miscellaneous Examples
  • Other examples <- Json schema glossary -> JSON schema keywords
  • JSON schema glossary <- Miscellaneous examples
  • Other examples -> JSON Schema glossary
  • Dialect and vocabulary declaration -> Value restrictions
  • Comments -> Enumerated values
  • JSON schema reference <- Specification overview

Modified Correct navigations :

  • Get started overview -> What is a schema ?
  • The basics <- Create your first schema -> JSON Schema glossary
  • Create your first schema <- JSON schema glossary -> Miscellaneous
  • JSON schema glossary <- Miscellaneous
  • Other examples -> Guides
  • Dialect and vocabulary declaration -> Enumerated and constant values
  • Comments -> Conditional Schema validation
  • Media : String encoding non-JSON data <- Specification Overview

Issue Number:

Sample relevant screenshot is attached below.

Screenshots/videos:
image

If relevant, did you update the documentation?
No

Summary
This PR fixes all the incorrect navigations on JSON Schema Website

Does this PR introduce a breaking change?
No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@Utkarsh-123github Utkarsh-123github requested a review from a team as a code owner May 13, 2025 16:17
Copy link

github-actions bot commented May 13, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview b6ff0ad

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f06af75) to head (b6ff0ad).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1653   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member Author

Hi @DhairyaMajmudar ,
Kindly have a look over and review this PR whenever you have a moment.
Thank you🚀

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working perfect! Thank you so much @Utkarsh-123github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to Merge
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Various incorrect page navigation throughout JSON Schema website
2 participants