Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reusable UI Button component #1397

Closed

Conversation

smartcraze
Copy link

What kind of change does this PR introduce?

  • Feature: Adds a reusable Button component.

Issue Number:

Screenshots/videos:

Screenshot 2025-02-03 191122
Screenshot 2025-02-03 191134

        <Button variant='primary'>Primary Button</Button>
        <Button variant='secondary'>Secondary Button</Button>
        <Button variant='danger'>Danger Button</Button>
        <Button variant='success'>Success Button</Button>

If relevant, did you update the documentation?

NO

Summary
This PR introduces a reusable Button component to improve consistency and maintainability by replacing manual class name additions. It resolves the issue of design inconsistencies across the app.

Does this PR introduce a breaking change?

  • No.

@smartcraze smartcraze requested a review from a team as a code owner February 3, 2025 13:46
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Feb 3, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 650c92c

@DhairyaMajmudar
Copy link
Member

@smartcraze pls. don't open pull request without issue assignment and follow our community guidelines

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57a3894) to head (650c92c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1397   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          387       387           
  Branches       103       103           
=========================================
  Hits           387       387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smartcraze
Copy link
Author

can you assign that issue since i have already worked on that !

@smartcraze
Copy link
Author

Okay Fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Create a Reusable UI Button Component
2 participants