feat: Added Esc functionality and improve styling of cancel button in ToolingDetail modal #1328
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@thepiyush-303 good work with this PR, just a comment then we're good to go
styles/globals.css
Outdated
There was a problem hiding this comment.
Changes in this is not required pls. remove them
There was a problem hiding this comment.
@thepiyush-303 any update on this ?
There was a problem hiding this comment.
The functionality code looks good to me. @DhairyaMajmudar I rely on your decision on the styling/css changes.
thepiyush-303
force-pushed
the
feat/addEscFeatureModal
branch
from
801188c to
fc38ed7
Compare
|
Congratulations, @thepiyush-303 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Screencast.from.2025-01-19.02-05-36.webm
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?