-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue to review the contributing document and add a triage process proposal #538
Conversation
…oposal As per issue #508 this PR is intended to review the org wide contributing document and provide a standard approach for issues triage.
We currently use a modified Sensible Github Labels list of labels: https://github.com/Relequestual/sensible-github-labels. I'd like to continue to use that as the basis, and not have similar/overlapping labels to keep it consistent across the org. Broadly though, this looks good. I'd like to have all new issues have a I feel we should use all the severity labels defined. I think "priority" makes better sense given it's not nesecerily an issue of severity. Whatever we end up with, we also need to make sure it is applied to all active repos, which includes making sure they have the labels and an updated readme, which may just direct to this document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great first start, which puts us in a much better place than previous. Let's re-work per my comments. (Obviously, more comments and reviews welcome.)
Thanks @Relequestual . Sensible GitHub labels are pretty flexible and cover most use cases. Is there any place where we have documented what is the modification we are using? I just found : https://github.com/json-schema-org/json-schema-spec?tab=readme-ov-file#status |
Please take a look to the new version I just pushed. Hope it reflects all the feedback provided. |
There is a new version of the PR ready addressing all the comments received. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for doing this work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor suggestions, otherwise it looks great!
Thank you for your work on this. Looks so much better.
If you agree with the suggestions, please feel free to merge after accepting them 🥳
Co-authored-by: Ben Hutton <[email protected]>
Thanks for the review and the suggestions @Relequestual !! Let's merge it! |
Summary
GitHub Issue: #583
Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)
No