Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary rules for discussion #34

Merged
merged 8 commits into from
Jul 6, 2022
Merged

Preliminary rules for discussion #34

merged 8 commits into from
Jul 6, 2022

Conversation

ioggstream
Copy link
Contributor

@ioggstream ioggstream commented Jun 30, 2022

@ioggstream
Copy link
Contributor Author

TODO: format examples

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg
Copy link
Member

Thanks for taking a lead in this document @ioggstream.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg
Copy link
Member

The data-format="markdown" bits are a hack, but this can be cleaned up and formalized later, perhaps using some tabbed examples, as in the JSON-LD 1.1 specs.

@ioggstream
Copy link
Contributor Author

Thanks Gregg. I need to learn how to "re-spec", but I think we can focus on the ideas for now :)

@ioggstream ioggstream force-pushed the ioggstream-8 branch 2 times, most recently from 5a41dd8 to d07cd81 Compare July 1, 2022 08:59
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated
* it supports different encodings, including UTF-8, UTF-16 and UTF-32;
* it supports more data types than JSON;
* the structure of its documents, that is named YAML representation graph,
is a tree that can have cycles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has cycles, then it is not a tree.

I think the correct notion here is that of rooted graph

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchampin replaced. Could you PTAL and check if there are other incorrect terms, please? Thx++ R.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated
@@ -421,6 +569,91 @@ <h2>Fragment identifiers</h2>
<h3>Examples</h3>
<p class="ednote">FIXME</p>
</section>
<section id="faq" class="informative" data-format="markdown">
**NOTE** REMOVE THIS SECTION BEFORE PUBLICATION.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we remove it? Anything that documents the decisions made in the spec can be useful for future readers. Granted, it is not the same thing to write these FAQs for internal purpose, and to write them for future readers (the 2nd requires more work), so we may decide to remove some of them if that extra-work is deemed unnecessary. But in general, such an FAQ could be kept in the final document, IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can figure out some markup to add “rationale” notes, ideally with links to issues that record resolutions, either inline, or in an appendix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchampin I suggest to try to put everything that is relevant in the spec.

FAQ are useful during the editing process for people that want to comment. Once a document is released,
I think that most of the FAQ can just fit a blog post on the WG repository.

In general, most of the rationale will be on the repository, and we probably shouldn't stuff all the issue discussion inside the spec.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@ioggstream
Copy link
Contributor Author

Note that data-cite is no longer recommended by ReSpec, and they suggest xref instead, but it doesn't seem to actually work with specs we reference.

Filed #40

@ioggstream ioggstream marked this pull request as ready for review July 3, 2022 22:28
@ioggstream ioggstream changed the title [WIP] Preliminary rules for discussion Preliminary rules for discussion Jul 3, 2022
@ioggstream ioggstream requested review from gkellogg and pchampin July 3, 2022 22:28
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this is great; just a couple of small nits.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@ioggstream
Copy link
Contributor Author

@gkellogg all set. Feel free to merge, now.

spec/index.html Outdated Show resolved Hide resolved
  * Basic concepts and Core requirements
  * MUST UTF-8
  * comments are white spaces
  * anchored nodes are considered static
  * FAQ

Co-authored-by: Gregg Kellogg <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@ioggstream
Copy link
Contributor Author

Rebased.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
gkellogg and others added 3 commits July 5, 2022 09:50
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@ioggstream ioggstream mentioned this pull request Jul 5, 2022
@ioggstream ioggstream added this to the -00 milestone Jul 6, 2022
spec/index.html Outdated Show resolved Hide resolved
named anchors and so on.
</p>
<p>
A YAML-LD document is a [[YAML]] document
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with earlier content, there should be no "YAML document", but I wonder whether that means that there should also be no YAML-LD document -- i.e., whether YAML-LD must be streams just like YAML itself.

Suggested change
A YAML-LD document is a [[YAML]] document
A YAML-LD document is [[YAML]]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving this suggestion unmerged based on @ioggstream's comments on today's meeting. It can be re-added as an issue or PR if it is inconsistent.

Co-authored-by: Ted Thibodeau Jr <[email protected]>
@gkellogg
Copy link
Member

gkellogg commented Jul 6, 2022

This PR was discussed in the 2022-07-06 meeting, and it was agreed to merge.

@gkellogg gkellogg merged commit f9fd301 into main Jul 6, 2022
@gkellogg gkellogg deleted the ioggstream-8 branch July 6, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple documents in YAML char encoding: UTF-8 only? Round-trip safe json-ld -> yaml-ld -> json-ld
5 participants