Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub introduction / abstract #28

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Stub introduction / abstract #28

merged 2 commits into from
Jun 29, 2022

Conversation

ioggstream
Copy link
Contributor

@ioggstream ioggstream commented Jun 23, 2022 •
edited by pr-preview bot
Loading

This PR

Preview | Diff

@ioggstream ioggstream requested review from gkellogg and pchampin June 23, 2022 23:00
TallTed
TallTed reviewed Jun 23, 2022
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
TallTed
TallTed reviewed Jun 23, 2022
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
TallTed
TallTed reviewed Jun 23, 2022
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
@ioggstream @TallTed
Apply suggestions from code review
dd3212d 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
gkellogg
gkellogg approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add yourself as an editor of the spec.

@ioggstream
Copy link
Contributor Author

@gkellogg we can do it in a separate PR :) Feel free to merge in the meantime.

@gkellogg gkellogg added the spec Issue on specification label Jun 24, 2022
@gkellogg gkellogg merged commit 198f470 into main Jun 29, 2022
@gkellogg gkellogg deleted the ioggstream-8 branch June 29, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@anatoly-scherbakov anatoly-scherbakov anatoly-scherbakov approved these changes

@gkellogg gkellogg gkellogg approved these changes

@pchampin pchampin Awaiting requested review from pchampin

Assignees
No one assigned
Labels
spec Issue on specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ioggstream @gkellogg @anatoly-scherbakov @TallTed