Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for AC-DC VPW #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Nicals
Copy link

@Nicals Nicals commented Feb 14, 2025

DropTarget fix from vpxtool and manual eol added to inline end if

Table url: https://vpuniverse.com/files/file/12471-acdc-luci-stern-2013-vpw-mod/

@francisdb
Copy link
Contributor

francisdb commented Feb 14, 2025

If this replaces https://github.com/jsm174/vpx-standalone-scripts/tree/master/AC-DC%20LUCI%20Premium%20VR%20(Stern%202013)%20v1.1 you can remove that folder in the pr

I see that folder also contains a dmd patch so better keep it for reference

@francisdb
Copy link
Contributor

@jsm174 can you approve the ci workflow?

@dekay
Copy link
Contributor

dekay commented Feb 14, 2025

FYI @Nicals: as discussed (at length) on Discord, this table needs additional patching to work on what is now master for this reason: vpinball/vpinball#1939 (comment)

See also https://discord.com/channels/652274650524418078/1076655472846831667/1340048754220204095

@francisdb
Copy link
Contributor

Then we should check with VPW to see if there are plans to fix that part. However they usually stick to release versions. Is that also an issue in 10.8.0?

@dekay
Copy link
Contributor

dekay commented Feb 14, 2025

Is that also an issue in 10.8.0?

I am able to run nical's script with VPX - v10.8.0 Final (Rev. 9999 (unknown), linux OpenGL 64bits). It seems to be post-rebase code where it breaks for me, at least on Linux.

@francisdb
Copy link
Contributor

I don't think this is something we should be fixing here as it's also broken on 10.8.1 windows?

@dekay
Copy link
Contributor

dekay commented Feb 14, 2025

I don't think this is something we should be fixing here as it's also broken on 10.8.1 windows?

IMHO, the table is coded wrong so I don't see the harm in fixing the ID thing at the same time as other fixes regarding winescript. Lots of standalone users run master so you otherwise make the scope of this patch quite limited. However, if you have a contact with VPW that could quickly make that fix along with winescript related fixes, that would be ideal.

@francisdb
Copy link
Contributor

It's reported to VPW, but might take a while for them to make a new release.

@francisdb
Copy link
Contributor

But we can indeed add a fix here. Do I understand correctly that the linked issue has a fix that not fully works?

@dekay
Copy link
Contributor

dekay commented Feb 17, 2025

But we can indeed add a fix here. Do I understand correctly that the linked issue has a fix that not fully works?

If you mean the patch for the older 1.1 version of the table at this link, the table is playable but the light bloom is way out of whack. One of the fixes in the new 1.13 version was intended to address this issue.
image

@casefresh
Copy link

DropTarget fix from vpxtool and manual eol added to inline end if

Table url: https://vpuniverse.com/files/file/12471-acdc-luci-stern-2013-vpw-mod/

hi everyone, I'm not sure if this is the right place to post, but I have issues with some pinballs closing on batocera vpinball. for instance Goonies Never Say Die: when i put flex dmd to the second screen, i only have 2 monitors. i figured out how to get the points etc to display on the second screen, but it eventually crashes and goes to the main menu.

can i use another patch from another pinball game? i'm just don't know enough yet to get this working and how to make my own patches.

and how about when you have lora of pup files. do they go in their separate folders, or just have all the files under pupvideos all out of their folder understand pupvideo folder batocera needs.

batocera wiki for vpinball really doesn't explain it very well. i've read it a few times.

and final question. i feel like it's random when i get the second screen to work showing the points. is there a sure fire way of making this happen all the time with vpinball on batocera?
i know the whole dmd thing is fairly new. but it's definitely feels a little rocky with the second screen right now on batocera v42 Batocera.

thanks in advance to whoever can reply, cheers

@francisdb
Copy link
Contributor

Not really the place to ask batocera questions. You will be better off on discord:
Batocera server: https://discord.gg/DjFWgEXc
(not sure what channel to post)

For general linux visual pinball questions
Virtual Pinball Chat server: https://discord.gg/eytXrzUH
vpx-standalone channel: https://discord.gg/GCxDg9fE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants