Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsk_pr2_startup: specify prefix for laser_filters plugins #920

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

furushchev
Copy link
Member

According to PR2/pr2_navigation#27

@k-okada
Copy link
Member

k-okada commented Apr 26, 2018

So, we did not use shadow filters until now?

@k-okada
Copy link
Member

k-okada commented Apr 26, 2018

does this mean , if we PR2/pr2_navigation#27, we have to update our file?
or both PR2/pr2_navigation#27 and jsk_robot has wrong settings for laser filter and they are not working correctly right now. ?

@furushchev
Copy link
Member Author

furushchev commented Apr 27, 2018

@k-okada We have now a pipeline as followings:

fuga

Since the actual change before/after the pull request is only angular_bounds according to the discussion at PR2/pr2_navigation#27 , /tilt_scan_shadow_filtered and /tilt_scan_filtered topics should be affected.

So, we did not use shadow filters until now?

I think we usually use /tilt_scan raw topic in most cases. That's why we did not notice the problem here.

both PR2/pr2_navigation#27 and jsk_robot has wrong settings for laser filter and they are not working correctly right now?

Both settings now occur wrong behaviors. So I think it is ok to merge both upstream PR and this.
I checked it fixes the problem after patching this PR.

BEFORE

tilt_scan

AFTER

tilt_scan_after

@k-okada k-okada merged commit 549210a into jsk-ros-pkg:master Apr 27, 2018
@furushchev furushchev deleted the filter-prefix branch May 2, 2018 11:13
@furushchev furushchev added this to the 1.1.1 milestone May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants