-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_fetch_startup] Use audible_warning to speak diagnostics #1480
base: master
Are you sure you want to change the base?
[jsk_fetch_startup] Use audible_warning to speak diagnostics #1480
Conversation
need to fix CI of jsk-ros-pkg/jsk_common#1607 |
5887098
to
f88e7b3
Compare
I force-pushed because
|
I think we do not need to wait for upstream release. === jsk_robot/jsk_fetch_robot/jsk_fetch.rosinstall.melodic Lines 31 to 34 in 3d65836
In this branch, |
f88e7b3
to
5db8763
Compare
I force-pushed the commits to resolve conflicts. |
…atically reconnects
The latest commit f47f29d is cherry-picked from knorth55#282
However, |
wait for discussion #1562 (comment) |
@708yamaguchi Could you please resolve conflicts? |
Duplicate knorth55#223
I use
jsk_tools/audible_warning.py
instead ofjsk_fetch_startup/warning.py
's function of speaking diagnostic.jsk-ros-pkg/jsk_common#1607
I think it is important to unify the function of speaking diagnostic.