Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_pcl/OrganizedStatisticalOutlierRemoval] support several pointcloud type #2846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knorth55
Copy link
Member

this PR supports several point cloud type as xyzirt.
now this nodes only support xyzrgb.

@mqcmd196
Copy link
Member

? What happened to CI?

Post job cleanup.
/usr/bin/docker exec  3bc6fc00c[2](https://github.com/jsk-ros-pkg/jsk_recognition/actions/runs/11024597303/job/30618033143?pr=2846#step:11:2)a0cb532a512f8729db5968edbb17067e62fe9ffca5b3e5eb87e008 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

@knorth55 knorth55 closed this Oct 28, 2024
@knorth55 knorth55 reopened this Oct 28, 2024
@k-okada
Copy link
Member

k-okada commented Oct 29, 2024

/workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_pcl_ros/src/organized_statistical_outlier_removal_nodelet.cpp: In member function ?virtual void jsk_pcl_ros::OrganizedStatisticalOutlierRemoval::filterCloud(pcl::PCLPointCloud2::Ptr, pcl::PointIndices::Ptr, bool)?:
/workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_pcl_ros/src/organized_statistical_outlier_removal_nodelet.cpp:170:47: error: no matching function for call to ?pcl::StatisticalOutlierRemoval<pcl::PCLPointCloud2>::filter(std::vector<int>&)?
       sor.filter(pcl_indices_filtered->indices);
                                               ^
In file included from /usr/include/pcl-1.8/pcl/filters/filter_indices.h:43:0,
                 from /usr/include/pcl-1.8/pcl/filters/statistical_outlier_removal.h:43,
                 from /workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_pcl_ros/src/organized_statistical_outlier_removal_nodelet.cpp:39:
/usr/include/pcl-1.8/pcl/filters/filter.h:238:7: note: candidate: void pcl::Filter<pcl::PCLPointCloud2>::filter(pcl::Filter<pcl::PCLPointCloud2>::PCLPointCloud2&)
       filter (PCLPointCloud2 &output);
       ^~~~~~
/usr/include/pcl-1.8/pcl/filters/filter.h:238:7: note:   no known conversion for argument 1 from ?std::vector<int>? to ?pcl::Filter<pcl::PCLPointCloud2>::PCLPointCloud2& {aka pcl::PCLPointCloud2&}?
make[2]: *** [CMakeFiles/jsk_pcl_ros.dir/src/organized_statistical_outlier_removal_nodelet.cpp.o] Error 1
make[1]: *** [CMakeFiles/jsk_pcl_ros.dir/all] Error 2
make: *** [all] Error 2
cd /workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros; catkin build --get-env jsk_pcl_ros | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -

https://github.com/jsk-ros-pkg/jsk_recognition/actions/runs/11564823139/job/32190755001?pr=2846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants