Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_pcl_ros] Fix errors on test_octomap_server_contact_pr2.test #2821

Merged
merged 5 commits into from
Apr 5, 2024
Merged

[jsk_pcl_ros] Fix errors on test_octomap_server_contact_pr2.test #2821

merged 5 commits into from
Apr 5, 2024

Conversation

pazeshun
Copy link
Contributor

@pazeshun pazeshun commented Feb 7, 2024 •
edited
Loading

Includes #2819

I assume test_octomap_server_contact_pr2.test added in #2819 does not work in newly-installed environment.
I try to fix it by the following changes:

  • Add missing dependency of sample_octomap_server_contact_pr2.launch
    • I am not sure if it is OK to add (especially roseus)

@pazeshun pazeshun changed the title [jsk_pcl_ros] Fix CI errors on test_octomap_server_contact_pr2.test [jsk_pcl_ros] Fix errors on test_octomap_server_contact_pr2.test Feb 7, 2024
@pazeshun
Copy link
Contributor Author

pazeshun commented Apr 5, 2024

@k-okada Could you review this?

@k-okada k-okada merged commit 9087486 into jsk-ros-pkg:master Apr 5, 2024
11 checks passed
@pazeshun pazeshun deleted the fix_test_2817 branch April 5, 2024 08:58
@pazeshun pazeshun mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pazeshun @k-okada