[audio_video_recorder] Add audio_video_recorder_server and client library to audio_video_recorder #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could merge this feature into audio_video_recorder package. because If someone changed interface of audio_video_recorder , we need to change server program. If recorder and server program located in different package , they might forget to update server program to compatible with recorder program |
sktometometo
changed the title
knorth55
requested changes
Nov 10, 2021
audio_video_recorder/src/audio_video_recorder/audio_video_recorder_server.py
Outdated
Show resolved
Hide resolved
audio_video_recorder/src/audio_video_recorder/audio_video_recorder_client.py
Outdated
Show resolved
Hide resolved
knorth55
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add audio_video_recorder_server node and client library to audio_video_recorder package.
These provides ROS service/topic interface to audio_video_recorder.
See README.md for details.