Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new VoiceText API #296

Closed
wants to merge 13 commits into from
Closed

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Nov 24, 2021

Support new version of voice_text. voice text SDK to voice text API.
All the coming voice_text engine will use new voice text API, maybe...

TODO

  • MUST support parameters when playing sounds -> tested and worked
  • MUST write README, how to setup vtapi -> done
  • MUST test on sdk(previous VoiceText) version robot -> tested on fetch1075 and confirmed builds, works fine
  • FEATURE merge new source code to current source code -> done
  • FEATURE find the solution not using *cpp.in

@mqcmd196 mqcmd196 changed the title Support vtapi Support new VoiceText API Nov 24, 2021
@mqcmd196 mqcmd196 marked this pull request as ready for review November 24, 2021 12:26
@mqcmd196
Copy link
Member Author

mqcmd196 commented Nov 24, 2021

@k-okada I merged my source code into original version, by using #ifdef

@knorth55
Copy link
Member

please resolve the conflict.

@knorth55
Copy link
Member

and can you tell me when I should review this PR?

@@ -21,7 +21,7 @@
#ifdef USE_DUMMY_INCLUDE
#include "dummy/vt_dummy.h"
#else
#include "@VT_ROOT@/inc/vt_jpn.h"
#include "@VT_INCLUDE@"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can write

#include VT_INCLDUE

and compile this with -DCV_INCLUDE
so add

to camke file, for example

add_definitions(-D${VT_INCLUDE})

or

  set_target_properties(voice_text PROPERTIES COMPILE_FLAGS -D${VT_INCLUDE})

or use

#include "vt_jpn.h"

and

include_directories(${VT_ROOT}/inc) ????

@k-okada
Copy link
Member

k-okada commented Aug 19, 2022

waiting for FEATURE find the solution not using *cpp.in

@mqcmd196
Copy link
Member Author

mqcmd196 commented Nov 8, 2022

Closed via #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants