Add support for putting emails and URIs in SAN field #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionall, modernizes a bit for newer versions of Go: - Use more idiomatic errors in a few places - Remove use of deprecated ioutil package Fixes incorrect name for SANS: Server => Subject
|
rebased this on master and tested locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SANS are allowed to contain more than just domain names and IP addresses. This PR adds the ability to specify email addresses and URIs in the Subject Alternate Name field of the generated leaf certificates.
This is of particular interest when using client certificates as authentication mechanisms. An example of this usecase can be found here.
I did a little refactoring while I was in there to update the Go version, ignored the generated artifact from
go build, reduce some redundant parsing, and remove the deprecatedioutilpackage.