Update ongoing promise in async iterator return() method

Fixes #268.
jsdom · Feb 13, 2024 · 940ff34 · 940ff34
1 parent da99c31
commit 940ff34
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/constructs/interface.js b/lib/constructs/interface.js
@@ -477,10 +477,10 @@ class Interface {
               return internal.target[implSymbol][utils.asyncIteratorReturn](this, value);
             };
 
-            const returnPromise = internal.ongoingPromise ?
+            internal.ongoingPromise = internal.ongoingPromise ?
               internal.ongoingPromise.then(returnSteps, returnSteps) :
               returnSteps();
-            return returnPromise.then(() => newObjectInRealm(globalObject, { value, done: true }));
+            return internal.ongoingPromise.then(() => newObjectInRealm(globalObject, { value, done: true }));
           }
         `;
       }

diff --git a/test/__snapshots__/test.js.snap b/test/__snapshots__/test.js.snap
@@ -1254,10 +1254,10 @@ exports.install = (globalObject, globalNames) => {
         return internal.target[implSymbol][utils.asyncIteratorReturn](this, value);
       };
 
-      const returnPromise = internal.ongoingPromise
+      internal.ongoingPromise = internal.ongoingPromise
         ? internal.ongoingPromise.then(returnSteps, returnSteps)
         : returnSteps();
-      return returnPromise.then(() => newObjectInRealm(globalObject, { value, done: true }));
+      return internal.ongoingPromise.then(() => newObjectInRealm(globalObject, { value, done: true }));
     }
   });
 
@@ -12630,10 +12630,10 @@ exports.install = (globalObject, globalNames) => {
         return internal.target[implSymbol][utils.asyncIteratorReturn](this, value);
       };
 
-      const returnPromise = internal.ongoingPromise
+      internal.ongoingPromise = internal.ongoingPromise
         ? internal.ongoingPromise.then(returnSteps, returnSteps)
         : returnSteps();
-      return returnPromise.then(() => newObjectInRealm(globalObject, { value, done: true }));
+      return internal.ongoingPromise.then(() => newObjectInRealm(globalObject, { value, done: true }));
     }
   });