Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested var() and nested calc() #179

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Support nested var() and nested calc() #179

merged 5 commits into from
Jan 9, 2025

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented Dec 20, 2024 •
edited
Loading

Fixes #125, closes #127

Based on #127. Many thanks.

@asamuzaK asamuzaK marked this pull request as draft December 26, 2024 05:18
@asamuzaK asamuzaK marked this pull request as ready for review December 27, 2024 02:02
@asamuzaK
Copy link
Contributor Author

PR ready.

domenic
domenic approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@domenic domenic merged commit bab4fcd into jsdom:main Jan 9, 2025
3 checks passed
@asamuzaK asamuzaK deleted the calc branch January 9, 2025 06:47
@bawjensen bawjensen mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow var functions in style.color values
2 participants
@asamuzaK @domenic