Infinite ping

[radulucut]

Adds support for the --infinite flag on the ping command.

• --limit will be set to max 5 when used with --infinite
• --packets default to 16 when --infinite is used

Example

globalping ping cdn.jsdelivr.net from Europe --infinite
> EU, SE, Stockholm, ASN:42708, GleSYS AB
PING  (142.250.186.46) 56(84) bytes of data.
64 bytes from fra24s04-in-f14.1e100.net (142.250.186.46): icmp_seq=1 ttl=59 time=25.2 ms
64 bytes from fra24s04-in-f14.1e100.net (142.250.186.46): icmp_seq=2 ttl=59 time=24.9 ms
64 bytes from fra24s04-in-f14.1e100.net (142.250.186.46): icmp_seq=3 ttl=59 time=25.2 ms
64 bytes from fra24s04-in-f14.1e100.net (142.250.186.46): icmp_seq=4 ttl=59 time=25.6 ms
64 bytes from fra24s04-in-f14.1e100.net (142.250.186.46): icmp_seq=5 ttl=59 time=28.2 ms
64 bytes from fra24s04-in-f14.1e100.net (142.250.186.46): icmp_seq=6 ttl=59 time=31.5 ms
^C

Example - multiple locations

globalping ping google.com from Europe --limit 5 --infinite
Location                                                  | Sent |    Loss |     Last |      Min |      Avg |      Max
EU, IT, Milan, ASN:16509, Amazon.com, Inc.                |    8 |   0.00% |  0.68 ms |  0.66 ms |  0.69 ms |  0.74 ms
EU, GB, London, ASN:20473, The Constant Company, LLC      |    7 |   0.00% |  1.25 ms |  1.24 ms |  1.29 ms |  1.35 ms
EU, DE, Essen, ASN:6805, Telefonica Germany GmbH & Co.OHG |    8 |   0.00% |  24.5 ms |  24.5 ms |  25.0 ms |  25.8 ms
EU, NO, Oslo, ASN:63473, HostHatch, LLC                   |    8 |   0.00% |  7.88 ms |  7.88 ms |  7.94 ms |  8.07 ms
EU, FR, Roubaix, ASN:16276, OVH SAS                       |    7 |   0.00% |  4.19 ms |  4.18 ms |  4.22 ms |  4.26 ms
^C

[jimaek]

Looks good, I think we could use this for the comparison feature as well. e.g. if user provides 2 endpoints then automatically use this formatting. @MartinKolarik what do you think?

[jimaek]

Regarding the PR itself, currently, in single probe mode, there is a delay that makes it look like it's stuck until it updates again. It should look more like normal ping, which looks and feels real-time. If there's a refresh delay then lets lower it.

The summary mode looks good on my environment.

[jimaek]

Please also follow the same format https://share.perfstack.net/2024/01/Termius_2024-01-18_18-02-14.png

[radulucut]

Multi-location live updates do not seem to work properly on Git Bash (I've raised an issue here), it appends a new table on every refresh.
Should I find an alternative or we can live with it for now?

[MartinKolarik]

Multi-location live updates do not seem to work properly on Git Bash (I've raised an issue pterm/pterm#616), it appends a new table on every refresh.

I don't have this issue, it only happened when I resized the terminal while the command was running. Without resizing, it worked fine.

• However, both in Git for Bash and the regular cmd.exe, the updating is quite slow and results in visible flicker. Not sure if we can do anything about it, but let's check: https://dl.dropboxusercontent.com/scl/fi/fpl36ie9qvfl09b5bpvy7/2024-01-19_16-52-02.gif?rlkey=yu31x2a7ofp135o1st9gy0gyl&dl=0 No problems when running in the same terminal app via WSL. I guess this issue was present before as well but in the regular output mode, it isn't as obvious.

[MartinKolarik]

Starting to look good! Haven't fully reviewed the code yet, but writing down what I've got so far.

[MartinKolarik]

Getting there 😄 please check the three small issues first, then let's see if we can improve the concurrency handling in a separate commit.

[MartinKolarik]

@jimaek please retest as well.

[MartinKolarik]

Merging, let's continue in #91.