Fixed osds_out/osds_down count + ceph iscsi GW reboot #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschmid1
requested changes
Jul 2, 2019
| @@ -49,21 +49,21 @@ def unset_noup(self): | |||
|
|
|||
| def get_down_osds(self): | |||
| data, _ = self.client.run_cmd('ceph osd tree -f json') | |||
| down_osds = [] | |||
| self.down_osds = [] | |||
There was a problem hiding this comment.
This is not neccessary. See L20: if this file
The constructor of this class is calling
self.down_osds = self.get_down_osds()
self.out_osds = self.get_out_osds()which makes the assignment of self.down_osds redundant.
If you encountered that down_osds is not populated you might the root cause in this function.
There was a problem hiding this comment.
the issue that I saw was that the self.out_osds was populated initially through the constructor but when the script is marking some disk out it doesn't get updated and that causes removing disks ignoring the threshold which in the end breaks the ceph cluster. I first checked the get_out_osds() function and it looks good.
| down_osds.append(node_osd.get('id')) | ||
| return down_osds | ||
| self.down_osds.append(node_osd.get('id')) | ||
| return self.down_osds | ||
|
|
||
| def get_out_osds(self): |
| @@ -30,8 +30,8 @@ def __init__(self): | |||
| self.vmwareops = VMwareOps() | |||
| self.ops.get_vm_list() | |||
|
|
|||
| if len(self.gateways) < 2: | |||
| self.reboot_allowed = False | |||
| if len(self.gateways) >= 2: | |||
There was a problem hiding this comment.
The reverted logic makes more sense here. Good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.