Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randoizer.js.org #4633

Merged
merged 2 commits into from
Sep 8, 2020
Merged

randoizer.js.org #4633

merged 2 commits into from
Sep 8, 2020

Conversation

milanmdev
Copy link
Contributor

@milanmdev
Copy link
Contributor Author

https://randoizer.js.org

MattIPv4
MattIPv4 requested changes Sep 7, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

@MattIPv4 MattIPv4 changed the title Update cnames_active.js randoizer.js.org Sep 7, 2020
milanmdev
milanmdev commented Sep 7, 2020
View reviewed changes
Copy link
Contributor Author

@milanmdev milanmdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it

@MattIPv4
Copy link
Member

MattIPv4 commented Sep 8, 2020

@milanmdev Do you have a link to where we can preview the content of the site before we merge this?

@MattIPv4 MattIPv4 added awaiting response This PR is waiting for a response from the requester and removed invalid labels Sep 8, 2020
@milanmdev
Copy link
Contributor Author

Yes. https://randoizer-docs-oxlxzss99.vercel.app

@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Sep 8, 2020
@indus
Copy link
Member

indus commented Sep 8, 2020

Welcome https://randoizer.js.org

@indus indus merged commit 4c0ff77 into js-org:master Sep 8, 2020
@milanmdev milanmdev deleted the patch-1 branch September 8, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milanmdev @MattIPv4 @indus