Skip to content

Commit

Permalink
Test with a matrix of bundler versions
Browse files Browse the repository at this point in the history
  • Loading branch information
iterateNZ authored and Phillip Aldridge committed Nov 7, 2023
1 parent b8ff9b8 commit c9c167a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 14 deletions.
19 changes: 6 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ jobs:

strategy:
matrix:
java-version: [8, 15]
ruby-version: [jruby-9.2.18.0, jruby-head]
java-version: [8, 11, 15]
ruby-version: [jruby-9.2.21.0, jruby-9.3.13.0, jruby-9.4.5.0, jruby-head]
bundler-version: [1.17.3, 2.4.21]
task: ['', integration]

fail-fast: false
Expand All @@ -37,20 +38,12 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler: 1.17.3

- name: Install fixed rubygems version for non-jruby-head
run: gem update --system 2.7.11
if: ${{ matrix.ruby-version != 'jruby-head' }}

# rubygems 2.7.11 is not supported on Ruby 3.1.0 (jruby-head).
# The oldest version supported by this ruby is 3.3.3.
- name: Install fixed rubygems version for jruby-head
run: gem update --system 3.3.3 && gem install bundler:1.17.3
if: ${{ matrix.ruby-version == 'jruby-head' }}
- name: Install latest rubygems version with bundler ${{ matrix.bundler-version }}
run: gem update --system && gem install bundler:${{ matrix.bundler-version }}

- name: Install dependencies
run: bundle _1.17.3_ install --jobs=3 --retry=3
run: bundle _${{ matrix.bundler-version }}_ install --jobs=3 --retry=3

- name: Run tests
run: bundle exec rake ${{ matrix.TASK }}
Expand Down
2 changes: 1 addition & 1 deletion spec/warbler/bundler_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def use_config(&block)
end

def bundle_install(*args)
`cd #{Dir.pwd} && #{RUBY_EXE} -S bundle install #{args.join(' ')}`
`cd #{Dir.pwd} && #{RUBY_EXE} -S bundle _#{::Bundler::VERSION}_ install #{args.join(' ')}`
end

let(:config) { drbclient.config(@extra_config) }
Expand Down

0 comments on commit c9c167a

Please sign in to comment.