Accept series-level scopecontent #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optionally accepts a field "series scopecontent" as series-level scopecontent tag. Does not add scope to arrangement section. Seems to pass included tests.
Deleted vestige of my messings-around.
Requires ability to set XML tag attributes, which are built into the field_map with hashes.
Pretty straightforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally accepts a field "series scopecontent" as series-level scopecontent tag. Does not add scope to arrangement section. Seems to pass included tests.
Pull Request Note: This simple change seems to work for me, but I'm not really sure if it's done well. I basically have no ruby experience.