Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on Clang/ARM (r161757). #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build on Clang/ARM (r161757). #2

wants to merge 1 commit into from

Conversation

pliard-chromium
Copy link

No description provided.

@pliard-chromium
Copy link
Author

Hi Jeff,

Can you please take a look at this patch? We had to fix this in Chromium when we rolled a new version of Clang. It would be great if we could get that in so that we don't differ too much in Chromium from upstream qcms.

Thanks,
Philippe.

@jrmuizel
Copy link
Owner

Yeah. I'll try to get to this today.

@pliard-chromium
Copy link
Author

Thanks Jeff! The patch has changed slightly while it was being reviewed in Chromium (mostly nits in comments). I'm not familiar with GitHub, should I close this pull request and create a new one or can I iterate on it (by adding a new commit and then squash the two commits together)?

@jrmuizel
Copy link
Owner

A new pull request is probably easier

Lupillo07

This comment was marked as spam.

Sign in to view

@Lupillo07

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lupillo07 Lupillo07 Lupillo07 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pliard-chromium @jrmuizel @Lupillo07