Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caption color of first render with dark theme #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix caption color of first render with dark theme #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions streamlit_image_select/frontend/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,6 @@ function onRender(event: Event): void {
// Get the RenderData from the event
const data = (event as CustomEvent<RenderData>).detail

if (data.theme) {
labelDiv.style.font = data.theme.font
labelDiv.style.color = data.theme.textColor
if (data.theme.base === "dark") {
document.body.querySelectorAll(".box, .caption").forEach((el) => {
el.classList.add("dark")
})
} else {
document.body.querySelectorAll(".box, .caption").forEach((el) => {
el.classList.remove("dark")
})
}

// TODO: Gray out the component if it's disabled.
}

label.textContent = data.args["label"]
let images = data.args["images"]
let captions = data.args["captions"]
Expand Down Expand Up @@ -72,6 +56,22 @@ function onRender(event: Event): void {
})
}

if (data.theme) {
labelDiv.style.font = data.theme.font
labelDiv.style.color = data.theme.textColor
if (data.theme.base === "dark") {
document.body.querySelectorAll(".box, .caption").forEach((el) => {
el.classList.add("dark")
})
} else {
document.body.querySelectorAll(".box, .caption").forEach((el) => {
el.classList.remove("dark")
})
}

// TODO: Gray out the component if it's disabled.
}

// We tell Streamlit to update our frameHeight after each render event, in
// case it has changed. (This isn't strictly necessary for the example
// because our height stays fixed, but this is a low-cost function, so
Expand Down