Issue #284 Handle ssl connections #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, What do you think about this? |
* `RedisPublisher` handles `ssl` flag * Update docs
|
Hello @jrief. |
|
@gtnx would you like to take the maintenance of this library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisPublisherhandlessslflagBtw, i've used black for the small parts i've changed. Have you considered using this tool. It really reduces time spent on code formatting and let developers focus on what matters.
In terms of testing, afaik travis does not support natively ssl redis-servers. Since modifications relies on well-tested code (
redis.SSLConnection), i guess it's ok not to test it thoroughly.