Adding support to cross domains. #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/changelog.rst
Outdated
| @@ -6,6 +6,11 @@ Release History | |||
|
|
|||
| 0.4.7 develop | |||
| ------------- | |||
|
|
|||
| Instalation settings: | |||
|
please rebase your pull request |
The setting WEBSOCKET_HOST enables using Websockets in cross domains. This is, the websocket domain (e.g. ws.myapp.com) is different from the site domain (e.g. www.myapp.com). However, it is mandatory to provide the Django setting SESSION_COOKIE_DOMAIN (e.g. SESSION_COOKIE_DOMAIN = '.myapp.com').
The setting WEBSOCKET_HOST enables using Websockets in cross domains. This is, the websocket domain (e.g. ws.myapp.com) is different from the site domain (e.g. www.myapp.com). However, it is mandatory to provide the Django setting SESSION_COOKIE_DOMAIN (e.g. SESSION_COOKIE_DOMAIN = '.myapp.com').
The setting WEBSOCKET_HOST enables using Websockets in cross domains. This is, the websocket domain (e.g. ws.myapp.com) is different from the site domain (e.g. www.myapp.com). However, it is mandatory to provide the Django setting SESSION_COOKIE_DOMAIN (e.g. SESSION_COOKIE_DOMAIN = '.myapp.com').
Adding cross domain support.
|
Pull request rebased. |
|
Closing this pull request because it is a little bit out of sync. I will perform some tests before opening another pull request. |
|
I've tested it with Django 1.8.18 and 1.11.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added the setting WEBSOCKET_HOST. This enables using websockets in cross domains. This is, the websocket domain (e.g. ws.myapp.com) is different from the site domain (e.g. www.myapp.com). However, it is mandatory to provide the Django setting SESSION_COOKIE_DOMAIN (e.g. SESSION_COOKIE_DOMAIN = '.myapp.com'). This pull request is backwards compatible. Documentation and changelog were updated accordingly.