-
Notifications
You must be signed in to change notification settings - Fork 155
added support for callbacks from gogiel/delayed_paperclip #196
base: master
Are you sure you want to change the base?
Conversation
Do you know how to add a callback for failure? |
@slin1202 hmmm not sure if paperclip will trigger an exception in that case... maybe checking if the style exists on "post_processing_callback" would solve your problem? |
Ah that might work, thanks! |
Fix broken spec
Hi everybody (@filipepina @slin1202 ), Thanks. |
The reason it hasn’t been merged and closed is because the maintainers are doing this (and many other things) on their nights and weekends. Half of us don’t even have an application that uses delayed_paperclip anymore, so it’s very hard for us to test these scenarios ourselves.
|
@jrgifford ok, understand. Is there any chance that you merge it when I create another PR with this feature ported to latest version (with specs and updated docs)? |
@jrgifford nevermind. I have refactored myself out of need of this feature. Yet I need to say that the changes from this PR worked fine. Did not stumbled on any side-effects so far during time I have used it. |
added the following callbacks:
post_processing_callback
pre_processing_callback
post_update_callback
requested on issue #176