follower should not be able to block himself

issue tcocca#57
jrasanen · Mar 18, 2016 · 629bc4d · 629bc4d
1 parent c376bfa
commit 629bc4d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/acts_as_follower/followable.rb b/lib/acts_as_follower/followable.rb
@@ -86,6 +86,7 @@ def followed_by?(follower)
       end
 
       def block(follower)
+        return if follower == self
         get_follow_for(follower) ? block_existing_follow(follower) : block_future_follow(follower)
       end
 

diff --git a/test/acts_as_followable_test.rb b/test/acts_as_followable_test.rb
@@ -131,6 +131,16 @@ class ActsAsFollowableTest < ActiveSupport::TestCase
     end
 
     context "blocking a follower" do
+      context "self blocking" do
+        setup do
+          @jon.block(@jon)
+        end
+
+        should "not be able to block" do
+          assert_equal 0, @jon.blocked_followers_count
+        end
+      end
+
       context "in my following list" do
         setup do
           @jon.block(@sam)