Tests: Run Sizzle.uniqueSort on a copy of an input
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
fix-tests-uniqueSort
branch
from
e8443d2 to
ceb0ec2
Compare
mgol
changed the title
Sizzle.uniqueSort Arrayish tests more reliablesetDocument() in Sizzle.uniqueSort tests
mgol
commented
Sep 12, 2022
mgol
changed the title
setDocument() in Sizzle.uniqueSort testsSizzle.uniqueSort on a copy of an input
Avoid modifying input in the first `Sizze.uniqueSort` test by ensuring a copy of the test input is provided.
mgol
force-pushed
the
fix-tests-uniqueSort
branch
from
ceb0ec2 to
03e6152
Compare
|
@timmywil this is ready for review now. |
timmywil
approved these changes
Oct 3, 2022
gibson042
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid modifying input in the first
Sizze.uniqueSorttest by ensuring a copyof the test input is provided.