Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Migrate from Travis to GitHub Actions #482

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Tests: Migrate from Travis to GitHub Actions #482

merged 1 commit into from
Jan 10, 2022

Conversation

mgol
Copy link
Member

@mgol mgol commented Dec 29, 2021

No description provided.

@mgol mgol added this to the 2.3.6 milestone Dec 29, 2021
@mgol mgol self-assigned this Dec 29, 2021
@mgol mgol marked this pull request as ready for review December 29, 2021 23:29
@mgol mgol requested review from gibson042 and timmywil December 29, 2021 23:29
@mgol
Copy link
Member Author

mgol commented Dec 29, 2021

The GitHub Actions workflow for this PR run tests on Chrome & Firefox & it succeeded. A workflow for the same code previously pushed to a branch on the this repo, not my fork successfully run tests on many browsers on BrowserStack. It looks like it works!

@mgol
Copy link
Member Author

mgol commented Dec 29, 2021

Since there's just a single job here, we could make it a required one in GitHub settings for this repo easily after this PR is merged.

@mgol mgol modified the milestones: 2.3.6, 2.3.7 Dec 30, 2021
timmywil
timmywil approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol
Copy link
Member Author

mgol commented Jan 5, 2022

@timmywil I moved NODE_VERSION from the strategy.matrix to a top-level env variable as otherwise it was influencing the build name and thus I wouldn't be able to set it as a required check without mentioning the Node.js version. I now made it a required check and it seems to be working fine as can be seen on this PR.

@mgol mgol merged commit ede0e97 into jquery:main Jan 10, 2022
@mgol mgol deleted the github-actions branch January 10, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

@gibson042 gibson042 Awaiting requested review from gibson042

Assignees

@mgol mgol

Labels
None yet
Milestone
2.3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @timmywil