Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Test for Shadow DOM v1 support #464

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 16, 2019

There was a test for Shadow DOM nodes working as root but it was using Shadow
DOM v0 that only Chromium implements and which it plans to remove in the future.
The test was reworked to rely on Shadow DOM v1.

jQuery master already uses the new API in its tests.

@mgol mgol requested review from timmywil and gibson042 October 16, 2019 14:53
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There was a test for Shadow DOM nodes working as root but it was using Shadow
DOM v0 that only Chromium implements and which it plans to remove in the future.
The test was reworked to rely on Shadow DOM v1.

jQuery master already uses the new API in its tests.
@mgol mgol force-pushed the shadow-dom-tests branch from 1a1501e to fb6c9ca Compare October 16, 2019 15:40
@mgol
Copy link
Member Author

mgol commented Oct 16, 2019

PR updated to check for both document.body.attachShadow and document.body.getRootNode as we do in jQuery 3.x as that's needed for Firefox 60 which supports Shadow DOM but not creating new Shadow roots. It now passes in all browsers.

@mgol mgol merged commit dd77482 into jquery:master Oct 21, 2019
@mgol mgol deleted the shadow-dom-tests branch October 21, 2019 16:50
@mgol mgol added this to the 2.3.5 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants