Build: Run Karma tests sequentially in separate processes + other improvements #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firefox issue is fixed in a separate PR: #456. |
gibson042
approved these changes
Aug 20, 2019
A new "karma-tests" task is created; it runs tests in various browser sets but does it sequentially in separate processes to avoid Karma bugs that cause browsers from previous sets to somehow still be waited on during subsequent runs, failing the build.
|
Given one approval, I'm going to merge it to see if |
|
Here we are, the first successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sizzle hasn't been able to finish all its unit tests successfully for a long time. This PR attempts to make it work again (at least most of the time).
but does it sequentially in separate processes to avoid Karma bugs that cause
browsers from previous sets to somehow still be waited on during subsequent
runs, failing the build.
We can't upgrade Karma as the latest version (
4.2.0) hangs in IE 7 (IE 8 seems to work fine there).Note: it's expected that tests fail on this PR when merged due to #454. I temporarily disabledEDIT: That issue is fixed now.oldFirefoxtests & pushed it to origin to see if it will succeed other than that and it did: https://travis-ci.org/jquery/sizzle/builds/574066624