Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Identifier with bad escape" test fails in Firefox 3.6 #454

Closed
mgol opened this issue Aug 19, 2019 · 1 comment
Closed

The "Identifier with bad escape" test fails in Firefox 3.6 #454

mgol opened this issue Aug 19, 2019 · 1 comment
Milestone
2.3.5

Comments

@mgol
Copy link
Member

mgol commented Aug 19, 2019

The Identifier with bad escape test fails in Firefox 3.6:
Screen Shot 2019-08-20 at 00 31 21
This is a new test, added in b2b650b (PR #450).
@mgol mgol added this to the 2.3.4 milestone Aug 19, 2019
This was referenced Aug 19, 2019
Closed
Merged
mgol added a commit to mgol/sizzle that referenced this issue Aug 19, 2019
@mgol
Selector: Detect incorrect escape handling by old Firefox
c181155 
Fixes jquerygh-454
mgol added a commit to mgol/sizzle that referenced this issue Aug 19, 2019
@mgol
Selector: Detect incorrect escape handling by old Firefox
5942cc7 
According to:
https://www.w3.org/TR/css-syntax-3/#ident-token-diagram
the escape doesn't need to be followed by a whitespace only if it's not a hex
digit or a newline. However, old Firefox (3.6 - 5 only) doesn't throw if an
escaped newline is not followed by a space. Fallback to Sizzle in such cases.

Fixes jquerygh-454
@mgol mgol mentioned this issue Aug 19, 2019
Closed
@mgol
Copy link
Member Author

mgol commented Aug 19, 2019

PR: #456

mgol added a commit to mgol/sizzle that referenced this issue Aug 20, 2019
@mgol
Selector: Detect incorrect escape handling by old Firefox
63ffa98 
According to:
https://www.w3.org/TR/css-syntax-3/#ident-token-diagram
the escape doesn't need to be followed by a whitespace only if it's not a hex
digit or a newline. However, old Firefox (3.6 - 5 only) doesn't throw if an
escaped newline is not followed by a space. Fallback to Sizzle in such cases.

Fixes jquerygh-454
mgol added a commit to mgol/sizzle that referenced this issue Aug 20, 2019
@mgol
Selector: Detect incorrect escape handling by old Firefox
32cfb01 
According to:
https://www.w3.org/TR/css-syntax-3/#ident-token-diagram
the escape doesn't need to be followed by a whitespace only if it's not a hex
digit or a newline. However, old Firefox (3.6 - 5 only) doesn't throw if an
escaped newline is not followed by a space. Fallback to Sizzle in such cases.

Fixes jquerygh-454
@mgol mgol closed this as completed in 11767a1 Aug 20, 2019
@mgol mgol modified the milestones: 2.3.4, 2.3.5 Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.3.5
Development

Successfully merging a pull request may close this issue.

Selector: Detect incorrect escape handling by old Firefox mgol/sizzle
1 participant
@mgol