Skip to content

Commit

Permalink
Build: remove stale Insight package from custom builds
Browse files Browse the repository at this point in the history
Close gh-5182
  • Loading branch information
timmywil authored Dec 20, 2022
1 parent 09d988b commit c66d470
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 42 deletions.
42 changes: 1 addition & 41 deletions build/tasks/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ module.exports = function( grunt ) {
const rollup = require( "rollup" );
const slimBuildFlags = require( "./lib/slim-build-flags" );
const rollupFileOverrides = require( "./lib/rollup-plugin-file-overrides" );
const Insight = require( "insight" );
const pkg = require( "../../package.json" );
const srcFolder = path.resolve( `${ __dirname }/../../src` );
const read = function( fileName ) {
return grunt.file.read( `${ srcFolder }/${ fileName }` );
Expand Down Expand Up @@ -339,46 +337,8 @@ module.exports = function( grunt ) {
const modules = args.length ?
args[ 0 ].split( "," ).join( ":" ) :
"";
const done = this.async();
const insight = new Insight( {
trackingCode: "UA-1076265-4",
pkg: pkg
} );

function exec( trackingAllowed ) {
let tracks = args.length ? args[ 0 ].split( "," ) : [];
const defaultPath = [ "build", "custom" ];

tracks = tracks.map( function( track ) {
return track.replace( /\//g, "+" );
} );

if ( trackingAllowed ) {

// Track individuals
tracks.forEach( function( module ) {
const path = defaultPath.concat( [ "individual" ], module );

insight.track.apply( insight, path );
} );

// Track full command
insight.track.apply( insight, defaultPath.concat( [ "full" ], tracks ) );
}

grunt.task.run( [ "build:*:*" + ( modules ? ":" + modules : "" ), "uglify", "dist" ] );
done();
}

grunt.log.writeln( "Creating custom build...\n" );

// Ask for permission the first time
if ( insight.optOut === undefined ) {
insight.askPermission( null, function( _error, result ) {
exec( result );
} );
} else {
exec( !insight.optOut );
}
grunt.task.run( [ "build:*:*" + ( modules ? ":" + modules : "" ), "uglify", "dist" ] );
} );
};
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"grunt-npmcopy": "0.2.0",
"gzip-js": "0.3.2",
"husky": "4.2.5",
"insight": "0.10.3",
"jsdom": "19.0.0",
"karma": "^6.3.17",
"karma-browserstack-launcher": "1.6.0",
Expand Down

0 comments on commit c66d470

Please sign in to comment.