Support extracting javadoc HTML files generated by Javadoc 17 #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 113 113
Lines 10277 10277
Branches 4088 4088
=======================================
Hits 8963 8963
Misses 718 718
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Big thanks. I keep hoping one day that javadoc would modernize with a css such that the pages are easier to parse. It has never happened. |
|
I do not have the opportunity to test this and just trust you @GorgiAstro that you did it. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 17 breaks the javadoc HTML file format again...
This proposal adds support for extracting HTML files generated by javadoc 17.
However, there is one bug that I didn't manage to fix after several hours of debugging: with javadoc 17 HTML files, there is a whitespace wrongly trimmed between
public classand the name of the class. For instance,public class OpenIntToFieldHashMapis wrongly transformed topublic classOpenIntToFieldHashMap.I attached a ZIP file containing two HTML javadoc files from the same java code, one exported with java 11, one with java 17.
However, I didn't check the backwards compatibility with java 8 and 14 for instance, I only checked with Java 11 and 17.
example_html_javadoc_11_vs_17.zip