Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with other customizable markdown standards #28

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

WalissonRodrigo
Copy link

I am integrating slack via webhooks into my react application however slack partially uses markdown when I have formatting in the text content. So bold, italic, underline, etc ... need styles different from the standard generated by the library in version 0.6.0. As I needed to solve my problem I thought about sharing my solution in the main project.

Basically the previous version is not affected and nothing is completely changed, not by my local tests.
So whoever needs to integrate a Slack of life like me can change the properties they want generating a final text that is very consistent with what their integration expects.

Another problem was the line break that was not included in the string itself and that in my integration it was necessary to render the text breaks correctly.

Walisson Rodrigo added 2 commits February 3, 2021 10:20
refatoração da estrutura inicialmente criada para permitir estilos em linha customizados pelo config.
atualização do readme com detalhes de como implementar o que foi mudado.
345 / 5000
Resultados de tradução
inclusion of optional line break via config.
refactoring the structure initially created to allow inline styles customized by the config.
update readme with details on how to implement what has been changed.
tested code without the new changes maintaining its old and standard functioning.
total adaptation to the markdown used in the slack
Copy link
Author

@WalissonRodrigo WalissonRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant