-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with other customizable markdown standards #28
Open
WalissonRodrigo
wants to merge
13
commits into
jpuri:master
Choose a base branch
from
WalissonRodrigo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refatoração da estrutura inicialmente criada para permitir estilos em linha customizados pelo config. atualização do readme com detalhes de como implementar o que foi mudado. 345 / 5000 Resultados de tradução inclusion of optional line break via config. refactoring the structure initially created to allow inline styles customized by the config. update readme with details on how to implement what has been changed. tested code without the new changes maintaining its old and standard functioning. total adaptation to the markdown used in the slack
WalissonRodrigo
commented
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am integrating slack via webhooks into my react application however slack partially uses markdown when I have formatting in the text content. So bold, italic, underline, etc ... need styles different from the standard generated by the library in version 0.6.0. As I needed to solve my problem I thought about sharing my solution in the main project.
Basically the previous version is not affected and nothing is completely changed, not by my local tests.
So whoever needs to integrate a Slack of life like me can change the properties they want generating a final text that is very consistent with what their integration expects.
Another problem was the line break that was not included in the string itself and that in my integration it was necessary to render the text breaks correctly.