Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 5.10 #811

Merged
merged 5 commits into from
May 3, 2024
Merged

Support Swift 5.10 #811

merged 5 commits into from
May 3, 2024

Conversation

johnfairh
Copy link
Collaborator

@johnfairh johnfairh commented Feb 29, 2024

(e: hit the button too soon...)

Main thing is that SwiftPM's yaml file changed format which needs some actual coding. Fixture updates minimal:

cursorinfo

  • Replacement of Foo.Protocol with Foo.Type for protocol metatypes
  • @_eagerMove appearing on Swift.String (no, me neither)

objc

  • Ubiquitous any for Swift versions of APIs eg. any NSCopying

Code completion

  • any in various fields
  • a load of completions have disappeared but they all seem to be for Double leaving just the Int ones which seems like an improvement

@johnfairh johnfairh changed the title Jf swift 510 Support Swift 5.10 Feb 29, 2024
@johnfairh johnfairh marked this pull request as ready for review April 4, 2024 12:45
@johnfairh
Copy link
Collaborator Author

johnfairh commented Apr 4, 2024

Unexpected struggle getting this to work: Xcode 15.3 has an undocumented feature in xcodebuild and other places where environment variables from the invoking environment are discarded. This includes DEVELOPER_DIR.

So when sourcekitten tries to fork xcodebuild, it gets the system default version (15.0.1 in the GHA image) which does not work.

Changed CI to use the xcode-select method instead. This is only necessary for the xcodebuild runner but I changed the others for consistency.

Dev forums, FB linked from there.

(Presumably intended as a hermetic testing improvement but shame on them for not mentioning it, or coordinating with SwiftPM, or…)

@johnfairh
Copy link
Collaborator Author

Longer than I meant to take getting back to this.

Apple has confirmed that this env. var thing is working as designed -- sounds like the alternative to xcode-select is to set both DEVELOPER_DIR and TEST_RUNNER_DEVELOPER_DIR. I think using xcode-select is probably fine & the right advice for consumers.

@jpsim fyi, will merge this in a few days.

@johnfairh johnfairh merged commit d6abc1f into jpsim:main May 3, 2024
18 checks passed
@johnfairh johnfairh deleted the jf-swift-510 branch May 3, 2024 11:42
@jpsim
Copy link
Owner

jpsim commented May 5, 2024

Thanks for driving all this, @johnfairh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants