Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable missing next theme in qas #4214

Merged
merged 5 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/ag-grid-theme/src/examples/Default.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ const Default = ({
containerClassName,
});

const statusBar = {
statusPanels: [
{
statusPanel: "agTotalRowCountComponent",
align: "right",
},
],
};

return (
<div {...containerProps}>
<AgGridReact
Expand Down Expand Up @@ -37,6 +46,7 @@ const Default = ({
]}
rowData={dataGridExampleData}
rowSelection="single"
statusBar={statusBar}
enableRangeSelection={true}
/>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/dialog/Dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export const Dialog = forwardRef<HTMLDivElement, DialogProps>(

const id = useId(idProp);

const currentbreakpoint = useCurrentBreakpoint();
const currentBreakpoint = useCurrentBreakpoint();

const [showComponent, setShowComponent] = useState(false);

Expand Down Expand Up @@ -154,7 +154,7 @@ export const Dialog = forwardRef<HTMLDivElement, DialogProps>(
}}
className={clsx(
withBaseName(),
withBaseName(size, currentbreakpoint),
withBaseName(size, currentBreakpoint),
{
[withBaseName("enterAnimation")]: open,
[withBaseName("exitAnimation")]: !open,
Expand Down
15 changes: 14 additions & 1 deletion packages/core/stories/form-field/form-field.qa.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,20 @@ export const AllVariantsGrid: StoryFn<QAContainerProps> = (props) => (
);

AllVariantsGrid.parameters = {
chromatic: { disableSnapshot: false },
chromatic: {
disableSnapshot: false,
modes: {
theme: {
themeNext: "disable",
},
themeNext: {
themeNext: "enable",
corner: "rounded",
accent: "teal",
// Ignore headingFont given font is not loaded
},
},
},
};

export const NoStyleInjectionGrid: StoryFn<QAContainerNoStyleInjectionProps> = (
Expand Down
15 changes: 14 additions & 1 deletion packages/core/stories/link/link.qa.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,20 @@ export const AllVariantsGrid: StoryFn<QAContainerProps> = (props) => (
);

AllVariantsGrid.parameters = {
chromatic: { disableSnapshot: false },
chromatic: {
disableSnapshot: false,
modes: {
theme: {
themeNext: "disable",
},
themeNext: {
themeNext: "enable",
corner: "rounded",
accent: "teal",
// Ignore headingFont given font is not loaded
},
},
},
};

export const NoStyleInjectionGrid: StoryFn<QAContainerNoStyleInjectionProps> = (
Expand Down
9 changes: 8 additions & 1 deletion packages/core/stories/list-box/list-box.qa.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ListBox, Option } from "@salt-ds/core";
import { ListBox, Option, OptionGroup } from "@salt-ds/core";
import type { Meta, StoryFn } from "@storybook/react";
import { QAContainer, type QAContainerProps } from "docs/components";
import { shortColorData } from "../assets/exampleData";
Expand Down Expand Up @@ -28,6 +28,13 @@ export const AllExamples: StoryFn<QAContainerProps> = () => (
<Option key={color} value={color} />
))}
</ListBox>
<ListBox>
<OptionGroup label="B">
{shortColorData.slice(0, 4).map((color) => (
<Option key={color} value={color} />
))}
</OptionGroup>
</ListBox>
</QAContainer>
);

Expand Down
15 changes: 14 additions & 1 deletion packages/core/stories/pagination/pagination.qa.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,18 @@ export const AllExamplesGrid: StoryFn<QAContainerProps> = (props) => {
};

AllExamplesGrid.parameters = {
chromatic: { disableSnapshot: false },
chromatic: {
disableSnapshot: false,
modes: {
theme: {
themeNext: "disable",
},
themeNext: {
themeNext: "enable",
corner: "rounded",
accent: "teal",
// Ignore headingFont given font is not loaded
},
},
},
};
Loading