Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update themes legacy to current #4086

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update themes legacy to current #4086

wants to merge 4 commits into from
+17 −17

Conversation

origami-z
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 10:46am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c160863

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amritadesmet
Update index.mdx
2fff600 
- Changed some of the written language
- Added in capital letters at specific places
- Replaced Legacy with "current" where necessary
origami-z
origami-z commented Sep 12, 2024
View reviewed changes
site/docs/themes/index.mdx
@@ -12,7 +12,7 @@ Salt theme is a collection of defined visual styles that shape the overall look-

A theme in Salt enables delivery teams to streamline the process of creating a consistent design language across their business domain, platforms or products.

### Design tokens
### Design Tokens
Copy link
Contributor Author

@origami-z origami-z Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence case for heading is part of content guide. go/uitk/content/3.writing-style/#sentence-case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Design Tokens" is title case, sentence case is where only the first letter of the sentence is capitalised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@origami-z @joshwooding @amritadesmet