Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dialog background scroll #3907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liamsms
Copy link
Contributor

@liamsms liamsms commented Jul 29, 2024

Closes #3906

  • Sets the root overflow to 'hidden' to prevent background scrolling while the Dialog is open, same approach as MUI.
  • Scrolling within the Dialog still works as expected.
  • Moved the cleanup callback to a new useEffect with no dependencies to prevent a race condition where the overflow style was sometimes not removed.
  • Tested on Chrome/Windows.

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: e2e20a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 29, 2024

@liamsms is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@liamsms
Copy link
Contributor Author

liamsms commented Jul 30, 2024

May require additional testing on a Mac due to potential differences in scroll behavior, eg. shifts in positioning when the scrollbar appears/disappears.

@liamsms liamsms marked this pull request as ready for review July 30, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable background scroll when Dialog open
1 participant