Nested stepped tracker #3803
Open
Nested stepped tracker #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1cc1e86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
7f41429
to
1cc1fe2
Compare
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
1cc1fe2
to
83bbf78
Compare
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
83bbf78
to
93e6458
Compare
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
93e6458
to
423672f
Compare
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
423672f
to
9bb92ed
Compare
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
9bb92ed
to
4d30b89
Compare
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
4d30b89
to
f266bf4
Compare
wrapping nested steps
tomhazledine
force-pushed
the
nested-stepped-tracker
branch
from
b59b906
to
1cc1e86
Compare
origami-z
reviewed
Sep 26, 2024
| /** | ||
| * The nesting depth of the TrackerStep | ||
| */ | ||
| depth?: Depth; |
There was a problem hiding this comment.
Not sure whether this is compared with NavigationItem's level.
Worth to point out this will take no effect when horizontal?
There was a problem hiding this comment.
level makes sense (and I'm always in favour of consistency)
| .saltTrackerStepWrapper-nested-group[aria-hidden="true"] { | ||
| grid-template-rows: 0fr; | ||
| opacity: 0; | ||
| visibility: hidden; |
There was a problem hiding this comment.
Not sure whether hidden on HTML will solve this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1869
Adds support for nesting steps in a vertical SteppedTracker.
Nesting is achieved via the
depthprop on theTrackerStepcomponent. When a step has nested children, the step icon will show an "in progress" icon when some of the children are completed, and a "completed" icon when all children are completed.