Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable background scroll when Dialog open #3906

Open
1 task done
liamsms opened this issue Jul 29, 2024 · 3 comments · May be fixed by #3907
Open
1 task done

Disable background scroll when Dialog open #3906

liamsms opened this issue Jul 29, 2024 · 3 comments · May be fixed by #3907
Labels
component: dialog status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working

Comments

@liamsms
Copy link
Contributor

liamsms commented Jul 29, 2024

Area

UI Components

The problem

The current behavior of the Dialog component allows for background scrolling when the Dialog is open. This can sometimes lead to unintentionally scrolling the background content while interacting with the Dialog. It would be nice to have an option to disable this.

The solution

Add a new prop to Dialog which disables background scrolling. eg disableBackgroundScrolling: boolean

Alternatives and examples

.

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@liamsms liamsms added status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request labels Jul 29, 2024
@joshwooding joshwooding added type: bug 🪲 Something isn't working component: dialog and removed type: enhancement 💡 New feature or request labels Jul 29, 2024
@joshwooding
Copy link
Contributor

This seems like a defect and should be fixed.

@liamsms liamsms linked a pull request Jul 29, 2024 that will close this issue
Open
@mark-tate
Copy link
Contributor

@tomhazledine @Fercas123 for awareness of the issue, what is our recommended solution

@mark-tate
Copy link
Contributor

grouped dialog issues into one sprint, needs further grooming, so dates subject to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dialog status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Dialog background scroll liamsms/salt-ds
3 participants
@mark-tate @joshwooding @liamsms