Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align to Salt Vertical Navigation pattern #607

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

mark-tate
Copy link
Contributor

  • groups now expand and collapse and do not select a route
  • sidebar group label can be defined through frontmatter sidebar.groupLabel
  • breadcrumbs do not display the root page
  • pagination now steps through all pages within the user journey
  • paginator buttons show the group, as well as the page title

@mark-tate mark-tate requested a review from a team as a code owner June 9, 2024 19:29
Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mosaic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 3:59pm

Copy link

changeset-bot bot commented Jun 9, 2024

🦋 Changeset detected

Latest commit: dcc48c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@jpmorganchase/mosaic-plugins Patch
@jpmorganchase/mosaic-site-components Patch
@jpmorganchase/mosaic-store Patch
@jpmorganchase/mosaic-site-preset-styles Patch
@jpmorganchase/mosaic-cli Patch
@jpmorganchase/mosaic-labs-components Patch
@jpmorganchase/mosaic-components Patch
@jpmorganchase/mosaic-content-editor-plugin Patch
@jpmorganchase/mosaic-core Patch
@jpmorganchase/mosaic-create-site Patch
@jpmorganchase/mosaic-from-http-request Patch
@jpmorganchase/mosaic-layouts Patch
@jpmorganchase/mosaic-open-api-component Patch
@jpmorganchase/mosaic-schemas Patch
@jpmorganchase/mosaic-serialisers Patch
@jpmorganchase/mosaic-site-middleware Patch
@jpmorganchase/mosaic-site Patch
@jpmorganchase/mosaic-sitemap-component Patch
@jpmorganchase/mosaic-source-figma Patch
@jpmorganchase/mosaic-source-git-repo Patch
@jpmorganchase/mosaic-source-http Patch
@jpmorganchase/mosaic-source-local-folder Patch
@jpmorganchase/mosaic-source-readme Patch
@jpmorganchase/mosaic-source-storybook Patch
@jpmorganchase/mosaic-standard-generator Patch
@jpmorganchase/mosaic-theme Patch
@jpmorganchase/mosaic-types Patch
@jpmorganchase/mosaic-workflows Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

    - groups now expand and collapse and do not select a route
    - sidebar group label can be defined through frontmatter `sidebar.groupLabel`
    - breadcrumbs do not display the root page
    - pagination now steps through all pages within the user journey
    - paginator buttons show the group, as well as the page title
@mark-tate mark-tate merged commit 727fcd5 into main Jun 10, 2024
8 checks passed
@mark-tate mark-tate deleted the remove-react-pro-sidebar branch June 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants