Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate toc #426

Closed
wants to merge 2 commits into from
Closed

Investigate toc #426

wants to merge 2 commits into from

Conversation

DavieReid
Copy link
Contributor

No description provided.

@DavieReid DavieReid requested a review from a team as a code owner July 27, 2023 14:14
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

⚠️ No Changeset found

Latest commit: 63e8780

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mosaic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 2:19pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5681674773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.261%
Totals Coverage Status
Change from base Build 5644651568: 0.0%
Covered Lines: 1306
Relevant Lines: 1802
💛 - Coveralls

mark-tate
mark-tate reviewed Jul 28, 2023
View reviewed changes
packages/site-components/src/TableOfContents/useIntersectionObserver.ts
};

const observer = new IntersectionObserver(handleIntersection, {
rootMargin: '-30% 0px -30% 0px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these feel a little magical, do they need to be configurable ?

@mark-tate
Copy link
Contributor

it works better, lets get it in and we can iterate as we need to

@DavieReid DavieReid marked this pull request as draft August 10, 2023 09:02
@DavieReid
Copy link
Contributor Author

Had discussions with design team...we want to revert back to having only 1 toc item selected at a time

@DavieReid
Copy link
Contributor Author

Another look at this and the implementation is likely to change again with the move to app directory

@DavieReid DavieReid closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavieReid @coveralls @mark-tate @joshwooding